Skip to content

refactor(material/core): reduce mixin function boilerplate #22637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

refactor(material/core): reduce mixin function boilerplate #22637

merged 1 commit into from
May 24, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 6, 2021

It seems like the various *Ctor interfaces for mixins aren't necessary anymore, because TS infers the type correctly without them. These changes clean up all the usages.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 6, 2021
@crisbeto crisbeto marked this pull request as ready for review May 6, 2021 18:35
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 6, 2021
jelbourn
jelbourn approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 7, 2021
devversion
devversion approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@crisbeto
refactor(material/core): reduce mixin function boilerplate
6a55e3f 
It seems like the various `*Ctor` interfaces for mixins aren't necessary anymore, because TS infers the type correctly without them. These changes clean up all the usages.
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 24, 2021
@wagnermaciel wagnermaciel merged commit 0a4dbe1 into angular:master May 24, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @wagnermaciel