fix(material-experimental/mdc-list): error with latest MDC list canary version #22636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: minor
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
fix/mdc-list-update-focus
branch
2 times, most recently
from
b96fd49 to
0f04f11
Compare
…y version MDC updated the focus strategy for lists with multi-selection enabled. This breaks our tests as we relied on the old strategy where the previously focused item always becomes the focus target. This is no longer the case as MDC now intends to focus the first selected item of a list instead (except for non-selection lists which are interactive; here the previously focused item is still used). We update the tests and update the selection list so that pre-selected options are recognized correctly so that MDC's new focus strategy works as expected. Before this change we didn't sync the pre-selected options with the MDC list foundation.
devversion
force-pushed
the
fix/mdc-list-update-focus
branch
from
0f04f11 to
22bdc30
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDC updated the focus strategy for lists with multi-selection enabled.
This breaks our tests as we relied on the old strategy where the
previously focused item always becomes the focus target.
This is no longer the case as MDC now intends to focus the first
selected item of a list instead (except for non-selection lists which
are interactive; here the previously focused item is still used).
We update the tests and update the selection list so that pre-selected
options are recognized correctly so that MDC's new focus strategy works
as expected. Before this change we didn't sync the pre-selected options
with the MDC list foundation.