Skip to content

fix(material-experimental/mdc-list): align foundation methods with MDC #22624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

fix(material-experimental/mdc-list): align foundation methods with MDC #22624

merged 1 commit into from
May 4, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented May 3, 2021

merge when cl/371742030 is in

@annieyw annieyw added merge safe target: patch This PR is targeted for the next patch release labels May 3, 2021
@annieyw annieyw requested a review from mmalerba May 3, 2021 21:56
@annieyw annieyw requested a review from devversion as a code owner May 3, 2021 21:56
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2021
mmalerba
mmalerba approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member

crisbeto commented May 4, 2021

It looks like the necessary changes in MDC made it into a canary version so you can get the CI green by bumping the version. Note that it might fail with the error fixed in #22623.

devversion
devversion approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw requested a review from a team as a code owner May 4, 2021 18:27
@josephperrott josephperrott removed the request for review from a team May 4, 2021 18:29
@annieyw annieyw added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 4, 2021
@annieyw annieyw merged commit 67d6a03 into angular:master May 4, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annieyw @crisbeto @devversion @mmalerba