fix(cdk/a11y): not restoring focus to elements inside the shadow DOM #22622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
The focus trap directive has the ability to restore focus to the previously-focused element on destroy automatically, however the logic doesn't account for the fact that `document.activeElement` will point to the shadow root if the element is inside the shadow DOM.
crisbeto
force-pushed
the
focus-trap-shadow-dom
branch
from
0b74ca7 to
fe48751
Compare
devversion
approved these changes
May 3, 2021
There was a problem hiding this comment.
LGTM. I chatted with @crisbeto about cases where multiple shadow DOM roots are nested. The plan is to revisit this (as we handle shadow DOM in other places too).
I guess having a shared function for getting the active element might be reasonable.
mmalerba
pushed a commit
that referenced
this pull request
May 7, 2021
…22622) The focus trap directive has the ability to restore focus to the previously-focused element on destroy automatically, however the logic doesn't account for the fact that `document.activeElement` will point to the shadow root if the element is inside the shadow DOM. (cherry picked from commit 706fc48)
mmalerba
pushed a commit
that referenced
this pull request
May 7, 2021
…22622) The focus trap directive has the ability to restore focus to the previously-focused element on destroy automatically, however the logic doesn't account for the fact that `document.activeElement` will point to the shadow root if the element is inside the shadow DOM. (cherry picked from commit 706fc48)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus trap directive has the ability to restore focus to the previously-focused element on destroy automatically, however the logic doesn't account for the fact that
document.activeElementwill point to the shadow root if the element is inside the shadow DOM.