Skip to content

build: remove unnecessary dependency in webdriver test #22621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

build: remove unnecessary dependency in webdriver test #22621

merged 1 commit into from
May 4, 2021

Conversation

devversion
Copy link
Member

Removes an unnecessary dependency being added to the
webdriver test. The NPM dependency doesn't seem to
be needed and increases the runfile tree by accident.

@devversion
build: remove unnecessary dependency in webdriver test
cfc0fca 
Removes an unnecessary dependency being added to the
webdriver test. The NPM dependency doesn't seem to
be needed and increases the runfile tree by accident.
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels May 3, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2021
josephperrott
josephperrott approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label May 3, 2021
@annieyw annieyw added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels May 4, 2021
@annieyw annieyw merged commit 7fe4925 into angular:master May 4, 2021
annieyw pushed a commit that referenced this pull request May 4, 2021
@devversion @annieyw
build: remove unnecessary dependency in webdriver test (#22621)
611c5a4 
Removes an unnecessary dependency being added to the
webdriver test. The NPM dependency doesn't seem to
be needed and increases the runfile tree by accident.

(cherry picked from commit 7fe4925)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @josephperrott @mmalerba @annieyw