Skip to content

fix(cdk/overlay): not emitting for auxiliary button clicks #22616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

fix(cdk/overlay): not emitting for auxiliary button clicks #22616

merged 1 commit into from
May 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 3, 2021

Similar to #21397. Fixes that the OverlayOutsideClickDispatcher doesn't emit when the user presses outside using the middle or right mouse button.

Also fixes some formatting.

@crisbeto
fix(cdk/overlay): not emitting for auxiliar button clicks
8060d62 
Similar to angular#21397. Fixes that the `OverlayOutsideClickDispatcher` doesn't emit when the user presses outside using the middle or right mouse button.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 3, 2021
@crisbeto crisbeto requested a review from jelbourn May 3, 2021 04:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2021
@crisbeto crisbeto changed the title fix(cdk/overlay): not emitting for auxiliar button clicks fix(cdk/overlay): not emitting for auxiliary button clicks May 3, 2021
jelbourn
jelbourn approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 3, 2021
@mmalerba mmalerba merged commit 65358a9 into angular:master May 7, 2021
mmalerba pushed a commit that referenced this pull request May 7, 2021
@crisbeto @mmalerba
fix(cdk/overlay): not emitting for auxiliar button clicks (#22616)
ba89398 
Similar to #21397. Fixes that the `OverlayOutsideClickDispatcher` doesn't emit when the user presses outside using the middle or right mouse button.

(cherry picked from commit 65358a9)
mmalerba pushed a commit that referenced this pull request May 7, 2021
@crisbeto @mmalerba
fix(cdk/overlay): not emitting for auxiliar button clicks (#22616)
97c449a 
Similar to #21397. Fixes that the `OverlayOutsideClickDispatcher` doesn't emit when the user presses outside using the middle or right mouse button.

(cherry picked from commit 65358a9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @mmalerba