Skip to content

fix(material/core): mat-ripple-element is not fired on disable #22537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021

Conversation

cynthialong0-0
Copy link
Contributor

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will somestimes not fire the
mat-ripple-element correctly. Adding the fadeOutAll() method when
set to disable will fix this issue.

Fixes #22520

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will somestimes not fire the
`mat-ripple-element` correctly. Adding the `fadeOutAll()` method when
set to disable will fix this issue.

Fixes angular#22520
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2021
When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes angular#22520
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the linter is failing though.

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes angular#22520
When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes angular#22520
@devversion devversion added G This is is related to a Google internal issue target: rc This PR is targeted for the next release-candidate labels Apr 26, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 26, 2021
@jelbourn
Copy link
Member

@devversion why target: rc and not patch?

@devversion
Copy link
Member

@jelbourn Ops. good point. For some reason I was thinking that we'd only target patch for critical issues.

@devversion devversion added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Apr 26, 2021
@annieyw annieyw merged commit 491d2ec into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
)

* fix(material/core): `mat-ripple-element` is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will somestimes not fire the
`mat-ripple-element` correctly. Adding the `fadeOutAll()` method when
set to disable will fix this issue.

Fixes #22520

* fix(material/core): mat-ripple-element is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes #22520

* fix(material/core): mat-ripple-element is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes #22520

* fix(material/core): mat-ripple-element is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes #22520

(cherry picked from commit 491d2ec)
annieyw pushed a commit that referenced this pull request May 3, 2021
)

* fix(material/core): `mat-ripple-element` is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will somestimes not fire the
`mat-ripple-element` correctly. Adding the `fadeOutAll()` method when
set to disable will fix this issue.

Fixes #22520

* fix(material/core): mat-ripple-element is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes #22520

* fix(material/core): mat-ripple-element is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes #22520

* fix(material/core): mat-ripple-element is not fired on disable

When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will sometimes not fire the
`mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method
in `ripple-renderer.ts` to fade out all non persistent ripples and let
it be triggered on disable. It should fix this issue.

Fixes #22520

(cherry picked from commit 491d2ec)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatRipple): mat-ripple-element is not fired correctly on disable
5 participants