-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/core): mat-ripple-element
is not fired on disable
#22537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will somestimes not fire the `mat-ripple-element` correctly. Adding the `fadeOutAll()` method when set to disable will fix this issue. Fixes angular#22520
When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes angular#22520
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like the linter is failing though.
When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes angular#22520
When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes angular#22520
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@devversion why |
@jelbourn Ops. good point. For some reason I was thinking that we'd only target patch for critical issues. |
) * fix(material/core): `mat-ripple-element` is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will somestimes not fire the `mat-ripple-element` correctly. Adding the `fadeOutAll()` method when set to disable will fix this issue. Fixes #22520 * fix(material/core): mat-ripple-element is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes #22520 * fix(material/core): mat-ripple-element is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes #22520 * fix(material/core): mat-ripple-element is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes #22520 (cherry picked from commit 491d2ec)
) * fix(material/core): `mat-ripple-element` is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will somestimes not fire the `mat-ripple-element` correctly. Adding the `fadeOutAll()` method when set to disable will fix this issue. Fixes #22520 * fix(material/core): mat-ripple-element is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes #22520 * fix(material/core): mat-ripple-element is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes #22520 * fix(material/core): mat-ripple-element is not fired on disable When button becomes disabled after the ripple initiated and before the ripple animation is completed, it will sometimes not fire the `mat-ripple-element` correctly. Add a `fadeOutAllNonPersistent` method in `ripple-renderer.ts` to fade out all non persistent ripples and let it be triggered on disable. It should fix this issue. Fixes #22520 (cherry picked from commit 491d2ec)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When button becomes disabled after the ripple initiated and before the
ripple animation is completed, it will somestimes not fire the
mat-ripple-element
correctly. Adding thefadeOutAll()
method whenset to disable will fix this issue.
Fixes #22520