refactor(material-experimental/mdc-list): no longer use deprecated styles #22530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
added
the
blocked
devversion
force-pushed
the
feat/mdc-list-switch-away-from-deprecated-styles
branch
2 times, most recently
from
50343a7 to
60bee47
Compare
devversion
force-pushed
the
feat/mdc-list-switch-away-from-deprecated-styles
branch
2 times, most recently
from
f6db643 to
bc212a5
Compare
…yles We recently switched the MDC list to deprecated styles as the MDC team started reworking the MDC list and our usage is not compatible. With this change, we start using the standard non-deprecated MDC list styles. This allows us to simplify a few custom CSS overrides due the new MDC list API being more aligned with the API we want to support for backwards comaptibility with the non-MDC list (e.g. per list-item icons and avatars instead of it being a per-list setting).
devversion
force-pushed
the
feat/mdc-list-switch-away-from-deprecated-styles
branch
from
bc212a5 to
81f2f0a
Compare
devversion
commented
Jun 2, 2021
| }, | ||
| { | ||
| from: 'Mary', | ||
| subject: 'Summer BBQ', | ||
| message: 'Wish I could come, but I have some prior obligations.', | ||
| image: 'https://angular.io/generated/images/bios/juleskremer.jpg' | ||
| image: 'https://angular.io/generated/images/bios/twerske.jpg' |
devversion
added
merge safe
target: patch
devversion
requested review from
crisbeto,
jelbourn,
mmalerba and
a team
as code owners
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently switched the MDC list to deprecated styles as the MDC team
started reworking the MDC list and our usage is not compatible.
With this change, we start using the standard non-deprecated MDC list
styles. This allows us to simplify a few custom CSS overrides due the
new MDC list API being more aligned with the API we want to support for
backwards compatibility with the non-MDC list (e.g. per list-item
icons and avatars instead of it being a per-list setting).