Skip to content

refactor(material-experimental/mdc-table): de-duplicate test harness logic #22451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

refactor(material-experimental/mdc-table): de-duplicate test harness logic #22451

merged 1 commit into from
May 7, 2021

Conversation

crisbeto
Copy link
Member

The logic for all the MDC table harnesses was identical. These changes pull it out into base classes in order to avoid repeating it.

@crisbeto
refactor(material-experimental/mdc-table): de-duplicate test harness …
9f24284 
…logic

The logic for all the MDC table harnesses was identical. These changes pull it out into base classes in order to avoid repeating it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 10, 2021
@crisbeto crisbeto requested a review from a team as a code owner April 10, 2021 12:59
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 10, 2021
mmalerba
mmalerba approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 12, 2021
@josephperrott josephperrott requested review from devversion and removed request for a team April 29, 2021 15:58
@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 7, 2021
@mmalerba mmalerba merged commit 6043957 into angular:master May 7, 2021
mmalerba pushed a commit that referenced this pull request May 7, 2021
@crisbeto @mmalerba
refactor(material-experimental/mdc-table): de-duplicate test harness …
483418e 
…logic (#22451)

The logic for all the MDC table harnesses was identical. These changes pull it out into base classes in order to avoid repeating it.

(cherry picked from commit 6043957)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @mmalerba