Skip to content

fix(google-maps): initialize directions service lazily #22302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ describe('MapDirectionsService', () => {
(window.google as any) = undefined;
});

it('initializes the Google Maps Directions Service', () => {
it('does not initialize the Google Maps Directions Service immediately', () => {
expect(directionsServiceConstructorSpy).not.toHaveBeenCalled();
});

it('initializes the Google Maps Directions Service when `route` is called', () => {
mapDirectionsService.route({}).subscribe();
expect(directionsServiceConstructorSpy).toHaveBeenCalled();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ export interface MapDirectionsResponse {
*/
@Injectable({providedIn: 'root'})
export class MapDirectionsService {
private readonly _directionsService: google.maps.DirectionsService;
private _directionsService: google.maps.DirectionsService|undefined;

constructor(private readonly _ngZone: NgZone) {
this._directionsService = new google.maps.DirectionsService();
}
constructor(private readonly _ngZone: NgZone) {}

/**
* See
Expand All @@ -38,6 +36,12 @@ export class MapDirectionsService {
*/
route(request: google.maps.DirectionsRequest): Observable<MapDirectionsResponse> {
return new Observable(observer => {
// Initialize the `DirectionsService` lazily since the Google Maps API may
// not have been loaded when the provider is instantiated.
if (!this._directionsService) {
this._directionsService = new google.maps.DirectionsService();
}

const callback =
(
result: google.maps.DirectionsResult|undefined,
Expand Down