Skip to content

fix(material-experimental/mdc-slider): dedup mdc-slider styles #22195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wagnermaciel
Copy link
Contributor

  • remove mdc-slider theme from theme.scss since it is already included in all-theme now
  • avoid using deprecated mdc-theme prop-value function in _slider-theme.scss

* remove mdc-slider theme from theme.scss since it is already included in all-theme now
* avoid using deprecated mdc-theme prop-value function in _slider-theme.scss
@wagnermaciel wagnermaciel requested a review from mmalerba March 11, 2021 18:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2021
@wagnermaciel wagnermaciel marked this pull request as ready for review March 11, 2021 18:48
@wagnermaciel wagnermaciel added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 11, 2021
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for devversion March 11, 2021 18:49
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit f3925a0 into angular:mdc-slider Mar 11, 2021
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 12, 2021
…ar#22195)

* remove mdc-slider theme from theme.scss since it is already included in all-theme now
* avoid using deprecated mdc-theme prop-value function in _slider-theme.scss
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 23, 2021
…ar#22195)

* remove mdc-slider theme from theme.scss since it is already included in all-theme now
* avoid using deprecated mdc-theme prop-value function in _slider-theme.scss
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Apr 1, 2021
…ar#22195)

* remove mdc-slider theme from theme.scss since it is already included in all-theme now
* avoid using deprecated mdc-theme prop-value function in _slider-theme.scss
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Apr 2, 2021
…ar#22195)

* remove mdc-slider theme from theme.scss since it is already included in all-theme now
* avoid using deprecated mdc-theme prop-value function in _slider-theme.scss
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Apr 8, 2021
…ar#22195)

* remove mdc-slider theme from theme.scss since it is already included in all-theme now
* avoid using deprecated mdc-theme prop-value function in _slider-theme.scss
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants