fix(google-maps): instantiate geocoder lazily #22159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
Currently we instantiate the `Geocoder` when the `MapGeocoder` provider is instantiated which may be too early if the Google Maps API is loaded lazily. These changes switch to creating it only when `geocode` is called. Fixes angular#22148.
crisbeto
force-pushed
the
22148/geocoder-lazy
branch
from
12d4033 to
278fbeb
Compare
andrewseguin
added
target: minor
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 20, 2021
Similar to angular#22159. Only initializes the Google Maps `DirectivesService` when calling `route`, because doing so in the constructor might be too early.
andrewseguin
pushed a commit
that referenced
this pull request
Mar 23, 2021
Similar to #22159. Only initializes the Google Maps `DirectivesService` when calling `route`, because doing so in the constructor might be too early.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we instantiate the
Geocoderwhen theMapGeocoderprovider is instantiated which may be too early if the Google Maps API is loaded lazily.These changes switch to creating it only when
geocodeis called.Fixes #22148.