Skip to content

fix(material-experimental/mdc-progress-bar): improve buffer color #22152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2021
Merged

fix(material-experimental/mdc-progress-bar): improve buffer color #22152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea23681
fix(material-experimental/mdc-progress-bar): improve buffer color
andrewseguin Mar 9, 2021
ed44384
fix(material-experimental/mdc-progress-bar): use color.adjust
andrewseguin Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/material-experimental/mdc-progress-bar/_progress-bar-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
// TODO(crisbeto): the buffer color should come from somewhere in MDC, however at the time of
// writing, their buffer color is hardcoded to #e6e6e6 which both doesn't account for theming
// and doesn't match the Material design spec. For now we approximate the buffer background by
// lightening the color of the primary bar.
$buffer-color: color.adjust(mdc-theme-color.prop-value($color), $lightness: 30%);
// applying an opacity to the color of the bar.
$buffer-color: color.adjust(mdc-theme-color.prop-value($color), $alpha: -0.75);
@include mdc-linear-progress.bar-color($color, $query: mdc-helpers.$mat-theme-styles-query);
@include mdc-linear-progress.buffer-color($buffer-color,
$query: mdc-helpers.$mat-theme-styles-query);
Expand Down