Skip to content

docs(dev-app): remove references to mdc-select placeholder #22135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 5, 2021

This was leftover from the legacy form-field appearance, which no longer
exists in MDC. Selects don't have a "placeholder" their equivalent would
be a null option

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels Mar 5, 2021
@mmalerba mmalerba requested a review from crisbeto as a code owner March 5, 2021 22:37
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 5, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a lint failure.

This was leftover from the legacy form-field appearance, which no longer
exists in MDC. Selects don't have a "placeholder" their equivalent would
be a null option
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 8, 2021
@mmalerba mmalerba merged commit 2a158f7 into angular:master Mar 10, 2021
mmalerba added a commit that referenced this pull request Mar 10, 2021
This was leftover from the legacy form-field appearance, which no longer
exists in MDC. Selects don't have a "placeholder" their equivalent would
be a null option

(cherry picked from commit 2a158f7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants