Skip to content

docs(material/table): use declarative idiomatic RxJS in table-http-example #22053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

docs(material/table): use declarative idiomatic RxJS in table-http-example #22053

merged 1 commit into from
Mar 5, 2021

Conversation

Splaktar
Copy link
Contributor

  • remove usages of subscribe()
  • fix jank and spinner covering table headers

Related to a GDE Slack question about teaching "using the "declarative" approach to RxJS. That means no subscribing in the component".

@Splaktar Splaktar self-assigned this Feb 28, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 28, 2021
@Splaktar Splaktar force-pushed the table-http-no-subscribe branch from 0ef5984 to 8a34612 Compare February 28, 2021 03:29
@Splaktar Splaktar added target: patch This PR is targeted for the next patch release P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Feb 28, 2021
crisbeto
crisbeto approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar
docs(material/table): use declarative idiomatic RxJS in table-http-ex…
2385f9d 
…ample

- remove usages of `subscribe()`
- fix jank and spinner covering table headers
@Splaktar Splaktar force-pushed the table-http-no-subscribe branch from 8a34612 to 2385f9d Compare March 1, 2021 18:44
@Splaktar Splaktar added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
@annieyw annieyw merged commit 67dc1fd into angular:master Mar 5, 2021
annieyw pushed a commit that referenced this pull request Mar 5, 2021
@Splaktar @annieyw
docs(material/table): use declarative idiomatic RxJS in table-http-ex…
f6fdc9e 
…ample (#22053)

- remove usages of `subscribe()`
- fix jank and spinner covering table headers

(cherry picked from commit 67dc1fd)
@Splaktar Splaktar deleted the table-http-no-subscribe branch March 5, 2021 04:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@Splaktar Splaktar

Labels
action: merge The PR is ready for merge by the caretaker area: material/table cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Splaktar @crisbeto @annieyw