Skip to content

refactor(material-experimental/mdc-core): clean up remaining @import usages #22045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

refactor(material-experimental/mdc-core): clean up remaining @import usages #22045

merged 1 commit into from
Mar 10, 2021

Conversation

crisbeto
Copy link
Member

Replaces all the remaining @import usages with @use.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Feb 26, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2021
mmalerba
mmalerba approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I imagine these will keep popping up unless we add a lint check

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
@crisbeto
Copy link
Member Author

crisbeto commented Mar 1, 2021

Yeah, I plan on adding a lint check once this is landed.

jelbourn
jelbourn approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, super readable with the mdc- aliases

@annieyw
Copy link
Contributor

annieyw commented Mar 3, 2021

Needs rebase @crisbeto

@crisbeto crisbeto force-pushed the sass-modules-cleanup branch from 5b4c067 to a2a32f7 Compare March 3, 2021 22:54
@crisbeto
Copy link
Member Author

crisbeto commented Mar 3, 2021

Rebased.

@crisbeto crisbeto force-pushed the sass-modules-cleanup branch from a2a32f7 to 11130e8 Compare March 5, 2021 17:51
@crisbeto crisbeto force-pushed the sass-modules-cleanup branch from 11130e8 to 54068f1 Compare March 9, 2021 20:28
@crisbeto
refactor(material-experimental/mdc-core): clean up remaining @import …
153c3ac 
…usages

Replaces all the remaining `@import` usages with `@use`.
@crisbeto crisbeto force-pushed the sass-modules-cleanup branch from 54068f1 to 153c3ac Compare March 9, 2021 20:31
@mmalerba mmalerba merged commit edadf8b into angular:master Mar 10, 2021
@mmalerba mmalerba mentioned this pull request Mar 11, 2021
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @annieyw @jelbourn @mmalerba @andrewseguin