Skip to content

docs(material/core): show typography as part of the theme #21810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2021
Merged

docs(material/core): show typography as part of the theme #21810

merged 1 commit into from
Feb 12, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 4, 2021

also recommend the mdc typography for the mdc components

@mmalerba mmalerba added docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Feb 4, 2021
@mmalerba mmalerba requested a review from jelbourn February 4, 2021 20:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 4, 2021
mmalerba
mmalerba commented Feb 4, 2021
View reviewed changes
jelbourn
jelbourn approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 5, 2021
@annieyw
Copy link
Contributor

annieyw commented Feb 9, 2021

@mmalerba needs rebase

@mmalerba
docs(material/core): show typography as part of the theme
4ea167c 
also recommend the mdc typography for the mdc components
@mmalerba
Copy link
Contributor Author

mmalerba commented Feb 9, 2021

done

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 12, 2021
@mmalerba mmalerba merged commit a41f866 into angular:master Feb 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @annieyw @jelbourn