feat(material-experimental/mdc-tooltip): implement MDC-based tooltip #21735
Conversation
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
google-cla
bot
added
the
cla: yes
| /** Animation that transitions a tooltip in and out. */ | ||
| tooltipState: trigger('state', [ | ||
| // TODO(crisbeto): these values are based on MDC's CSS. | ||
| // We should be able to use their styles directly once we land #19432. |
There was a problem hiding this comment.
why does this depend on making a change to the non-mdc tooltip?
There was a problem hiding this comment.
Tests will be harder to migrate between the two implementations if one is using Angular animations and the other is using CSS + with the animationend event. The linked PR will change the current tooltip to CSS-based animations. Also the timing might be different.
There was a problem hiding this comment.
Ok, we should see how hard it is to land #19432. If that proves difficult, I'm worried that not doing it with CSS from the start could make the MDC one impossible to change later too
Adds a tooltip directive based on top of MDC's styles.
…ngular#21735) Adds a tooltip directive based on top of MDC's styles.
…ngular#21735) Adds a tooltip directive based on top of MDC's styles.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a tooltip directive based on top of MDC's styles. Test harness will be added in a follow-up.