fix(material/select): VoiceOver reading out blank space #21733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some inline elements inside `mat-select` which may collapse if their text bindings are empty. To work around it we replace the content with a blank space. The problem is that VoiceOver seems to read out this text. These changes fix the issue by keeping the height of the elements using CSS instead. Fixes angular#21725.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Feb 2, 2021
We have some inline elements inside `mat-select` which may collapse if their text bindings are empty. To work around it we replace the content with a blank space. The problem is that VoiceOver seems to read out this text. These changes fix the issue by keeping the height of the elements using CSS instead. Fixes #21725. (cherry picked from commit 9f913aa)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
We have some inline elements inside `mat-select` which may collapse if their text bindings are empty. To work around it we replace the content with a blank space. The problem is that VoiceOver seems to read out this text. These changes fix the issue by keeping the height of the elements using CSS instead. Fixes angular#21725.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
We have some inline elements inside `mat-select` which may collapse if their text bindings are empty. To work around it we replace the content with a blank space. The problem is that VoiceOver seems to read out this text. These changes fix the issue by keeping the height of the elements using CSS instead. Fixes angular#21725.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some inline elements inside
mat-selectwhich may collapse if their text bindings are empty. To work around it we replace the content with a blank space. The problem is that VoiceOver seems to read out this text.These changes fix the issue by keeping the height of the elements using CSS instead.
Fixes #21725.