refactor(material/core): clean up deprecated API usages #21597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans a handful of usages of deprecated APIs.
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Jan 15, 2021
| @@ -209,7 +209,7 @@ export class MatExpansionPanel extends CdkAccordionItem implements AfterContentI | |||
| if (this._lazyContent) { | |||
| // Render the content as soon as the panel becomes open. | |||
| this.opened.pipe( | |||
| startWith(null!), | |||
There was a problem hiding this comment.
FYI I think this was necessary to avoid some rxjs typing breakage in google at some point. We'll see if it breaks anything in the presubmit.
jelbourn
added
merge: caretaker note
|
Caretaker note: if the rxjs |
crisbeto
changed the title
mmalerba
pushed a commit
that referenced
this pull request
Jan 19, 2021
Cleans a handful of usages of deprecated APIs. (cherry picked from commit 6bab3df)
mmalerba
pushed a commit
that referenced
this pull request
Jan 19, 2021
Cleans a handful of usages of deprecated APIs. (cherry picked from commit 6bab3df)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 20, 2021
Cleans a handful of usages of deprecated APIs.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans a handful of usages of deprecated APIs.