fix(material-experimental/mdc-chips): decouple removal from animation #21586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the MDC chips automatically trigger an animation that collapses the chip to 0x0 dimensions, but it still keeps it in the DOM unless the consumer updates their data source. This is misleading and there's no way for the consumer to see it. These changes bring the chip in line with our current behavior where we only dispatch the remove event and then it's up to the consumer to remove the chip. Making these changes also revealed some tests that were passing by accident and weren't actually testing the things they were supposed to, because the `animationend` event wasn't being dispatched. I've tweaked them in order to get them to work as expected. Fixes angular#21561.
google-cla
bot
added
the
cla: yes
crisbeto
added
P2
andrewseguin
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
LGTM - you're awesome @crisbeto, thanks for making this change
mmalerba
added
target: rc
mmalerba
pushed a commit
that referenced
this pull request
Jan 19, 2021
…#21586) Currently the MDC chips automatically trigger an animation that collapses the chip to 0x0 dimensions, but it still keeps it in the DOM unless the consumer updates their data source. This is misleading and there's no way for the consumer to see it. These changes bring the chip in line with our current behavior where we only dispatch the remove event and then it's up to the consumer to remove the chip. Making these changes also revealed some tests that were passing by accident and weren't actually testing the things they were supposed to, because the `animationend` event wasn't being dispatched. I've tweaked them in order to get them to work as expected. Fixes #21561. (cherry picked from commit 2d66ecb)
|
It looks like I ran the presubmit for this when a bunch of internal tests were broken. That caused it to skip all of the broken tests and made it appear that this was safe to merge. However, now that the tests are fixed, it appears this actually breaks a number of tests so I'll need to revert it for now. |
mmalerba
added a commit
that referenced
this pull request
Jan 20, 2021
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 20, 2021
…angular#21586) Currently the MDC chips automatically trigger an animation that collapses the chip to 0x0 dimensions, but it still keeps it in the DOM unless the consumer updates their data source. This is misleading and there's no way for the consumer to see it. These changes bring the chip in line with our current behavior where we only dispatch the remove event and then it's up to the consumer to remove the chip. Making these changes also revealed some tests that were passing by accident and weren't actually testing the things they were supposed to, because the `animationend` event wasn't being dispatched. I've tweaked them in order to get them to work as expected. Fixes angular#21561.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 20, 2021
…nimation (angular#21586)" (angular#21634) This reverts commit 2d66ecb.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MDC chips automatically trigger an animation that collapses the chip to 0x0 dimensions, but it still keeps it in the DOM unless the consumer updates their data source. This is misleading and there's no way for the consumer to see it.
These changes bring the chip in line with our current behavior where we only dispatch the remove event and then it's up to the consumer to remove the chip.
Making these changes also revealed some tests that were passing by accident and weren't actually testing the things they were supposed to, because the
animationendevent wasn't being dispatched. I've tweaked them in order to get them to work as expected.Fixes #21561.