fix(material-experimental/mdc-snack-bar): disable animations in noop #21377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
andrewseguin
added
target: patch
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Dec 16, 2020
| @@ -13,6 +13,10 @@ | |||
| @include cdk-high-contrast(active, off) { | |||
| border: solid 1px; | |||
| } | |||
|
|
|||
| &:not(._mat-animation-noopable) { | |||
There was a problem hiding this comment.
I think this is cleaner, but my concern is that the :not increases the specificity and it can make it difficult for people to override the styles.
There was a problem hiding this comment.
True - I'd rather not add the need for more specificity for the general case with animations. Changed to be straightforward with removing transition. The only danger is if MDC changes the animated styles but we can deal with that another time
andrewseguin
force-pushed
the
mdc-snack-anim
branch
from
7d7d59e to
006c1e7
Compare
mmalerba
added
the
P2
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.