fix(material-experimental/mdc-button): fix ripple noop animation #21360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the ripple animation to 0ms enter/exit if
NoopAnimationsModule
detected. Since the ripple animation must be passed it, and it overrides the module, we need to manually set thisFor discussion: This may be the wrong fix. The ripple's animation input declares this:
However, the logic does not adhere to this, and instead defers preference to the
this.animation
input: