Skip to content

fix(material/select): incorrect default typeahead debounce time #21253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

fix(material/select): incorrect default typeahead debounce time #21253

merged 1 commit into from
Dec 10, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 8, 2020 •
edited
Loading

In 17a9ad0 some logic was added that was setting the typeahead debounce interval to 0 if it isn't specified globally. This is incorrect, because we want it to stay undefined so the list key manager can fall back to its default interval.

Fixes #21242.

@crisbeto
fix(material/select): incorrect default typeahead debounce time
4c4b712 
In 17a9ad0 so logic was added that was
setting the typeahead debounce interval to 0 if it isn't specified globally.
This is incorrect, because we want it to stay undefined so the list key manager
can fall back to its default interval.

Fixes angular#21242.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 8, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 8, 2020
mmalerba
mmalerba approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Dec 9, 2020
@wagnermaciel wagnermaciel merged commit ab01f38 into angular:master Dec 10, 2020
wagnermaciel pushed a commit that referenced this pull request Dec 10, 2020
@crisbeto @wagnermaciel
fix(material/select): incorrect default typeahead debounce time (#21253)
8c56d06 
In 17a9ad0 so logic was added that was
setting the typeahead debounce interval to 0 if it isn't specified globally.
This is incorrect, because we want it to stay undefined so the list key manager
can fall back to its default interval.

Fixes #21242.

(cherry picked from commit ab01f38)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(select): typeahead with more than one character does not select the right option
3 participants
@crisbeto @mmalerba @wagnermaciel