Skip to content

fix(material/menu): clear static aria attributes from host node #21231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix(material/menu): clear static aria attributes from host node #21231

merged 1 commit into from
Dec 8, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 6, 2020

Clears the static aria- attributes from the menu host since they're forwarded to the menu overlay panel.

Fixes #21152.

@crisbeto
fix(material/menu): clear static aria attributes from host node
ca8795e 
Clears the static `aria-` attributes from the menu host since they're forwarded
to the menu overlay panel.

Fixes angular#21152.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 6, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2020
jelbourn
jelbourn approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2020
@wagnermaciel wagnermaciel merged commit 377378b into angular:master Dec 8, 2020
wagnermaciel pushed a commit that referenced this pull request Dec 8, 2020
@crisbeto @wagnermaciel
fix(material/menu): clear static aria attributes from host node (#21231)
f568af1 
Clears the static `aria-` attributes from the menu host since they're forwarded
to the menu overlay panel.

Fixes #21152.

(cherry picked from commit 377378b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatMenu aria-label is not cleared from dummy element
3 participants
@crisbeto @jelbourn @wagnermaciel