fix(material/datepicker): screen reader not announcing view switch button value #21229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton value The button for switching between calendar views has an `aria-label` along the lines of "Choose month" which overrides its default text. This means that the user has no way of knowing what is inside the button. These changes add a further `aria-describedby` pointing to the content which lets the screen reader announce both pieces of text. Note that an alternate approach is to concatenate the content into the `aria-label`, but I don't know how well that would work in RTL languages.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Dec 7, 2020
| cdkAriaLive="polite"> | ||
| {{periodButtonText}} | ||
| <span [attr.id]="_buttonDescriptionId">{{periodButtonText}}</span> |
wagnermaciel
pushed a commit
that referenced
this pull request
Dec 10, 2020
…tton value (#21229) The button for switching between calendar views has an `aria-label` along the lines of "Choose month" which overrides its default text. This means that the user has no way of knowing what is inside the button. These changes add a further `aria-describedby` pointing to the content which lets the screen reader announce both pieces of text. Note that an alternate approach is to concatenate the content into the `aria-label`, but I don't know how well that would work in RTL languages. (cherry picked from commit d4f2fa6)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button for switching between calendar views has an
aria-labelalong the lines of "Choose month" which overrides its default text. This means that the user has no way of knowing what is inside the button.These changes add a further
aria-describedbypointing to the content which lets the screen reader announce both pieces of text.Note that an alternate approach is to concatenate the content into the
aria-label, but I don't know how well that would work in RTL languages.