fix(cdk/schematics): fix resolving modules in ng update

[kyubisation]

Closes #21160

[kyubisation]

@crisbeto The material schematics tests run into a memory issue. I suspect this is due to the migration now correctly resolving all related files, but I cannot say for certain. Do you have an idea on how this could be fixed?

[crisbeto]

Even if it is resolving more files than before, we'd have to try really hard to get it to run out of memory. Could it be hitting an infinite loop somewhere? Also does this happen if you run the tests locally?

[kyubisation]

Yes, I'm trying to investigate it right now. I need to setup the bazel debugging...

[kyubisation]

I have currently narrowed it down to the material-imports.spec.ts and the hammer-migration-v9.spec.ts. I'm currently debugging it, to see what is happening.

[kyubisation]

Ok, the problem seems to be, that getDir in the HostTree treats a non-existent file path as a potential directory. This means getDir cannot be used to assert a path being a directory (and it also does not expose the isDirectory of its nested host).
I'll see if there is an alternative solution.

[kyubisation]

@crisbeto I have refactored the directory check to query, if the parent directory has the given directory as a subdir. Please have another look.

[crisbeto]

Thank you for reworking it, it's looking much better! One more comment and it should be good to go.

[crisbeto]

LGTM and thank you for taking the time to get rid of our old workaround.

[kyubisation]

No problem, thank you for the quick response. 😃
Do you think a release with this fix is possible this week or is that unlikely?
Depending on this we will wait for the release or try to provide a workaround internally in our company.

[crisbeto]

Since this is only schematics code, it can be merged in quicker, but I can't guarantee when it'll be released.

[kyubisation]

Ok, that's not a problem.
The workaround is to simply run ng update package --migrateOnly --from=10 --to=11, so we can live with that.

[kyubisation]

@crisbeto I tested this with a few real life projects from our company and discovered an additional problem. When projects import package.json, typescript checks potential entry points (e.g /package.json/package.json and /package.json/index.ts) which would result in a failure with getDir. To avoid this I added a check to verify that the parent "directory" is not an existing file.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}