refactor(material/core): resolve circular dependencies #21110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully the last set of code changes for the Sass module system migration. * Combines `theming/_theming.scss` and `theming/_private.scss`, because they had a circular dependency and since `theming.scss` could be considered a public API, we can't move the utilities out into a shared file. * Changes the `angular-material-density` mixin to include density mixins individually, instead of going through `angular-material-theme`. The previous approach had transient circular dependencies that will turn into hard errors once we switch to the Sass module system. The new approach is in line with what we're doing already inside `angular-material-typography`. * Switches a few MDC function calls to go through `@use` instead of `@import`. For some reason Sass was having a hard time finding the old ones after the files are migrated to the module system. * Passes a variable as a parameter to `mat-mdc-private-dialog-structure-overrides`, instead of expecting it to be available as a global variable. This seems like an oversight. * Fixes several places where mixins were being imported transitevely, rather than explicitly. This will be an error with the Sass module system.
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the last set of code changes for the Sass module system migration.
theming/_theming.scssandtheming/_private.scss, because they had a circular dependency and sincetheming.scsscould be considered a public API, we can't move the utilities out into a shared file.angular-material-densitymixin to include density mixins individually, instead of going throughangular-material-theme. The previous approach had transient circular dependencies that will turn into hard errors once we switch to theSass module system. The new approach is in line with what we're doing already inside
angular-material-typography.@useinstead of@import. For some reason Sass was having a hard time finding the old ones after the files are migrated to the module system.mat-mdc-private-dialog-structure-overrides, instead of expecting it to be available as a global variable. This seems like an oversight.Note: Setting as a P2, because it's a blocker for the Sass module system migration. I'm trying to fix all the errors ahead of time so that the final PR consists only of changes made by the migration script.