Skip to content

docs(material-experimental): css paths in readme #20957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

docs(material-experimental): css paths in readme #20957

merged 1 commit into from
Nov 4, 2020

Conversation

twerske
Copy link
Contributor

@twerske twerske commented Nov 3, 2020

Adds the correct import paths for mdc-components guide on scss/css @Mixins
Adds the angular-material-mdc-theme to a readme versus individual guides on css mixins.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2020
crisbeto
crisbeto approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message needs to be changed for the lint check to pass. You could try setting it to docs instead.

@twerske twerske changed the title fix(material-experimental): css paths in readme docs(material-experimental): css paths in readme Nov 3, 2020
@twerske
docs(material-experimental/mdc-theming): readmes
9667a06 
correct import paths for mdc-component scss
add readme for angular-material-mdc-theme
jelbourn
jelbourn approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Nov 3, 2020
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 4, 2020
@annieyw annieyw merged commit 2dcdd1b into angular:master Nov 4, 2020
@twerske twerske deleted the fix-readmes branch November 4, 2020 23:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twerske @jelbourn @crisbeto @annieyw