fix: set role on tooltip description element #20953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for an optional `role` to be assigned to the description element. This is required for some cases like tooltips (see angular#20593).
Sets the `tooltip` role on the tooltip's description element so it conveys more information to assistive technology. Fixes angular#20593.
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
added
merge: preserve commits
google-cla
bot
added
the
cla: yes
This comment has been minimized.
This comment has been minimized.
|
Did you see if this substantively changes the behavior of the tooltip in a scree-reader? |
|
I didn't really notice a change in NVDA, but all of the examples of accessible tooltips that I've been looking at had a role on the description element so I figured that there has to be a reason behind it. I decided to do it since it isn't a lot of maintenance on our part. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes two separate commits that:
rolethrough theAriaDescriber.tooltiprole on the tooltip's description elements.Fixes #20593.