Skip to content

fix(material/paginator): remove unnecessary @ViewChild in harness test #20943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix(material/paginator): remove unnecessary @ViewChild in harness test #20943

merged 1 commit into from
Nov 4, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Oct 30, 2020

No description provided.

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Oct 30, 2020
@annieyw annieyw requested a review from mmalerba October 30, 2020 23:31
@annieyw annieyw requested a review from andrewseguin as a code owner October 30, 2020 23:31
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2020
mmalerba
mmalerba approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 31, 2020
crisbeto
crisbeto approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw merged commit 7335c65 into angular:master Nov 4, 2020
annieyw added a commit that referenced this pull request Nov 4, 2020
@annieyw
fix(material/paginator): remove unnecessary @ViewChild in harness test (
2e39e63 
#20943)

(cherry picked from commit 7335c65)
annieyw added a commit that referenced this pull request Nov 4, 2020
@annieyw
fix(material/paginator): remove unnecessary @ViewChild in harness test (
28c70d3 
#20943)

(cherry picked from commit 7335c65)
@annieyw annieyw deleted the fix-paginator-harness-test branch November 9, 2020 19:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @crisbeto @mmalerba