Skip to content

fix(material-expeirmental/table): export missing symbols #20924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

fix(material-expeirmental/table): export missing symbols #20924

merged 1 commit into from
Oct 30, 2020

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested review from jelbourn and crisbeto October 29, 2020 20:37
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 29, 2020
@mmalerba mmalerba added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Oct 29, 2020
jelbourn
jelbourn approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we should refactor this into a base class in a follow up.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 29, 2020
@mmalerba mmalerba force-pushed the mdc-table-exports branch 2 times, most recently from 265b93d to e63c99d Compare October 29, 2020 20:53
@mmalerba mmalerba mentioned this pull request Oct 29, 2020
Merged
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 30, 2020
@wagnermaciel wagnermaciel merged commit f7d7502 into angular:master Oct 30, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @wagnermaciel