-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(cdk/layout): decrease breakpoint upper bounds #20866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@tomrlq could you amend your commit to be self-describing? Something like
|
The previous breakpoint upper bounds use `.99` for the fractional components of upper bounds. However, this seems to cause browser to round up to the next pixel, creating an overlap for these values. Changing to `.98` fixes this. Fixes angular#20850
I just amended the commit and force pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The previous breakpoint upper bounds use
.99
for thefractional components of upper bounds. However, this seems
to cause browser to round up to the next pixel, creating an overlap
for these values. Changing to
.98
fixes this.Fixes #20850