Skip to content

fix(cdk/layout): decrease breakpoint upper bounds #20866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

tomrlq
Copy link
Contributor

@tomrlq tomrlq commented Oct 23, 2020

The previous breakpoint upper bounds use .99 for the
fractional components of upper bounds. However, this seems
to cause browser to round up to the next pixel, creating an overlap
for these values. Changing to .98 fixes this.

Fixes #20850

@tomrlq tomrlq requested a review from jelbourn as a code owner October 23, 2020 00:58
@google-cla
Copy link

google-cla bot commented Oct 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 23, 2020
@tomrlq
Copy link
Contributor Author

tomrlq commented Oct 23, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 23, 2020
@tomrlq tomrlq changed the title Fix for angular/components#20850 Fix(cdk/layout) fix the upper boundary in BreakPoints to make matching result correct Oct 23, 2020
@tomrlq tomrlq changed the title Fix(cdk/layout) fix the upper boundary in BreakPoints to make matching result correct Fix(cdk/layout): fix the upper boundary to make matching result correct Oct 23, 2020
@jelbourn
Copy link
Member

@tomrlq could you amend your commit to be self-describing? Something like

fix(cdk/layout): decrease breakpoint upper bounds

The previous breakpoint upper bounds use `.99` for the
fractional components of upper bounds. However, this seems
to cause browser to round up to the next pixel, creating an overlap
for these values. Changing to `.98` fixes this.

Fixes #20850

The previous breakpoint upper bounds use `.99` for the
fractional components of upper bounds. However, this seems
to cause browser to round up to the next pixel, creating an overlap
for these values. Changing to `.98` fixes this.

Fixes angular#20850
@tomrlq tomrlq changed the title Fix(cdk/layout): fix the upper boundary to make matching result correct fix(cdk/layout): decrease breakpoint upper bounds Oct 26, 2020
@tomrlq
Copy link
Contributor Author

tomrlq commented Oct 26, 2020

could you amend your commit to be self-describing?

I just amended the commit and force pushed.

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Oct 27, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added area: cdk/layout action: merge The PR is ready for merge by the caretaker labels Oct 27, 2020
@annieyw annieyw merged commit 16576e4 into angular:master Nov 3, 2020
annieyw pushed a commit that referenced this pull request Nov 3, 2020
The previous breakpoint upper bounds use `.99` for the
fractional components of upper bounds. However, this seems
to cause browser to round up to the next pixel, creating an overlap
for these values. Changing to `.98` fixes this.

Fixes #20850

(cherry picked from commit 16576e4)
annieyw pushed a commit that referenced this pull request Nov 3, 2020
The previous breakpoint upper bounds use `.99` for the
fractional components of upper bounds. However, this seems
to cause browser to round up to the next pixel, creating an overlap
for these values. Changing to `.98` fixes this.

Fixes #20850

(cherry picked from commit 16576e4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/layout cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Breakpoints): Incorrect upper boundary lead to wrong match result
3 participants