Skip to content

fix(material/list): exclude icons from harness getText result #20845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix(material/list): exclude icons from harness getText result #20845

merged 1 commit into from
Oct 28, 2020

Conversation

crisbeto
Copy link
Member

Excludes icons and avatars from the MatListItemHarnessBase.getText result.

Fixes #20812.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 21, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 21, 2020
@crisbeto
fix(material/list): exclude icons from harness getText result
07556b4 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes angular#20812.
@crisbeto crisbeto force-pushed the 20812/list-harness-exclude branch from 5ebe26c to 07556b4 Compare October 21, 2020 07:06
jelbourn
jelbourn approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 21, 2020
@wagnermaciel wagnermaciel merged commit dfdd422 into angular:master Oct 28, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (#20845)
aec12b6 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.

(cherry picked from commit dfdd422)
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (#20845)
8638456 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.

(cherry picked from commit dfdd422)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatNavListItemHarness): getText() needs to exclude icons
4 participants
@crisbeto @jelbourn @annieyw @wagnermaciel