-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental/mdc-snack-bar): not aligned correctly on IE11 #20690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
reviewed
Sep 30, 2020
src/material-experimental/mdc-snack-bar/snack-bar-container.scss
Outdated
Show resolved
Hide resolved
We were hitting a flexbox bug that was causing the snack bar container to collapse on IE11, shifting it off-center when using the `center` alignment and pushing it completely off-screen in the `end` alignment.
6822b55
to
b828909
Compare
mmalerba
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 1, 2020
…iner Fixes a regression from angular#20690 that caused the snack bar button to be pushed outside of the container.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hitting a flexbox bug that was causing the snack bar container to collapse on IE11, shifting it off-center when using the
center
alignment and pushing it completely off-screen in theend
alignment.