Skip to content

fix(material-experimental/mdc-snack-bar): not aligned correctly on IE11 #20690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

crisbeto
Copy link
Member

We were hitting a flexbox bug that was causing the snack bar container to collapse on IE11, shifting it off-center when using the center alignment and pushing it completely off-screen in the end alignment.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Sep 30, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 30, 2020
We were hitting a flexbox bug that was causing the snack bar container to collapse
on IE11, shifting it off-center when using the `center` alignment and pushing it
completely off-screen in the `end` alignment.
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 30, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit c9fcbef into angular:master Sep 30, 2020
mmalerba pushed a commit that referenced this pull request Sep 30, 2020
…11 (#20690)

We were hitting a flexbox bug that was causing the snack bar container to collapse
on IE11, shifting it off-center when using the `center` alignment and pushing it
completely off-screen in the `end` alignment.

(cherry picked from commit c9fcbef)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 1, 2020
…iner

Fixes a regression from angular#20690 that caused the snack bar button to be pushed outside of the container.
mmalerba pushed a commit that referenced this pull request Oct 1, 2020
…iner (#20696)

Fixes a regression from #20690 that caused the snack bar button to be pushed outside of the container.
mmalerba pushed a commit that referenced this pull request Oct 1, 2020
…iner (#20696)

Fixes a regression from #20690 that caused the snack bar button to be pushed outside of the container.

(cherry picked from commit 50d3f29)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants