Skip to content

feat(material-experimental/mdc-paginator): add test harness #20686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

feat(material-experimental/mdc-paginator): add test harness #20686

merged 1 commit into from
Sep 30, 2020

Conversation

crisbeto
Copy link
Member

Sets up a test harness for the MDC-based paginator.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: minor This PR is targeted for the next minor release labels Sep 30, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner September 30, 2020 08:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 30, 2020
@crisbeto crisbeto changed the title feat(materiale-experimental/mdc-paginator): add test harness feat(material-experimental/mdc-paginator): add test harness Sep 30, 2020
@crisbeto
feat(material-experimental/mdc-paginator): add test harness
d4e08e7 
Sets up a test harness for the MDC-based paginator.
@crisbeto crisbeto force-pushed the mdc-paginator-harness branch from d6bc318 to d4e08e7 Compare September 30, 2020 08:27
mmalerba
mmalerba approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 30, 2020
@mmalerba
Copy link
Contributor

CARETAKER NOTE: Add an internal build rule for the new harness

@mmalerba mmalerba merged commit 49a57bc into angular:master Sep 30, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @googlebot