fix(cdk/tree): collapse child nodes if top level collapses #20683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 30, 2020
src/components-examples/cdk/tree/cdk-tree-flat/cdk-tree-flat-example.ts
Outdated
Show resolved
Hide resolved
bochalito
force-pushed
the
20665/flat-tree-child-nodes-not-collapse
branch
from
43f22df to
06373d3
Compare
crisbeto
reviewed
Sep 30, 2020
src/components-examples/cdk/tree/cdk-tree-flat/cdk-tree-flat-example.ts
Outdated
Show resolved
Hide resolved
Fixes a bug in the Angular CDK Tree examples where the children nodes are still visible when the top level node is collapsed. This is because the `shouldRender()` method of the `cdk-flat-tree-example.ts` is checking only the parent of current node. Fixes angular#20665
bochalito
force-pushed
the
20665/flat-tree-child-nodes-not-collapse
branch
from
06373d3 to
5dfafba
Compare
crisbeto
added
docs
mmalerba
added
the
merge: fix commit message
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Angular CDK Tree examples where the children nodes
are still visible when the top level node is collapsed. This is because
the
shouldRender()method of the cdk-flat-tree-example.ts is checkingonly the parent of current node.
Fixes #20665