Skip to content

test(material-experimental): add missing test coverage #20678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

crisbeto
Copy link
Member

Adds tests that were missing from the mdc-menu, mdc-radio, mdc-table and mdc-tabs modules.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Sep 29, 2020
@crisbeto crisbeto requested review from andrewseguin, mmalerba and a team as code owners September 29, 2020 09:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2020
Adds tests that were missing from the `mdc-menu` module.
Adds tests that were missing from the `mdc-radio` module.
Adds tests that were missing from the `mdc-table` module.
Adds tests that were missing from the `mdc-tabs` module.
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 30, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 2dbbc0d into angular:master Sep 30, 2020
mmalerba pushed a commit that referenced this pull request Sep 30, 2020
* test(material-experimental/mdc-menu): add missing test coverage

Adds tests that were missing from the `mdc-menu` module.

* test(material-experimental/mdc-radio): add missing test coverage

Adds tests that were missing from the `mdc-radio` module.

* test(material-experimental/mdc-table): add missing test coverage

Adds tests that were missing from the `mdc-table` module.

* test(material-experimental/mdc-tabs): add missing test coverage

Adds tests that were missing from the `mdc-tabs` module.

(cherry picked from commit 2dbbc0d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants