refactor(cdk/testing): simplify harnesses extending ContentContainerComponentHarness with a different root element #20646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
content-container-cleanup
branch
from
21cf573 to
86ef173
Compare
|
The Saucelabs failure seems to be due to an issue with Saucelabs themselves. |
mmalerba
reviewed
Sep 24, 2020
crisbeto
force-pushed
the
content-container-cleanup
branch
from
86ef173 to
dba3361
Compare
…omponentHarness with a different root element We have some test harnesses that extend `ContentContainerComponentHarness`, but have to override all methods, because their content is in a different element. These changes clean up such usages by having a protected method for retrieving the harness root element that can be overwritten when necessary.
crisbeto
force-pushed
the
content-container-cleanup
branch
from
dba3361 to
a8faff1
Compare
mmalerba
added
target: minor
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some test harnesses that extend
ContentContainerComponentHarness, but have to override all methods, because their content is in a different element.These changes clean up such usages by having a protected method for retrieving the harness root element that can be overwritten when necessary.