fix(cdk/testing): fix behavior in fakeAsync tests

[mmalerba]

No description provided.

[crisbeto]

If a Zone global variable isn't defined, this will still throw a TypeError. You'll have to guard it with typeof Zone !== 'undefined' to avoid the error, although I'm not sure how likely it is that we'll hit such a case.

[mmalerba]

Changed it back to ! which is what it actually was originally. I don't think we really support testing without zones currently anyways

[crisbeto]

LGTM

[thw0rted]

I've been trying to start using the TestbedHarnessEnvironment for a couple of days now, and I've had a lot of trouble. The component under test uses setInterval internally to update a property, so in the unit test, fixture.whenStable() never resolves. I'm still able to directly manipulate the fixture using fakeAsync tests, with a discardPeriodicTasks() at the end of each test.

I tried following the docs for using harnesses but my tests timeout at await loader.getAllHarnesses(...). Am I right in thinking that this is because getAllHarnesses is currently using whenStable under the hood, and that this patch addresses my problem? (If so, any idea when I can expect this to land in a release?)

[crisbeto]

@thw0rted I can't say whether it'll fix your problem, but the change is in the 11.0.0-next.1 release if you want to try it out.

[thw0rted]

Thanks @crisbeto, I will give it a shot.

I had meant my questions about behavior to be more aimed at @mmalerba, because the PR didn't have a description, nor did it link to an existing issue, so I had to try to guess at the motivation behind it. From the comments in the commits, it sounded sort of like what I was experiencing, but I wasn't sure.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}