Skip to content

refactor(cdk/schematics): change usages of whitelist in selector interfaces to fileTypeFilter #20619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2020
Merged

refactor(cdk/schematics): change usages of whitelist in selector interfaces to fileTypeFilter #20619

merged 3 commits into from
Sep 30, 2020

Conversation

josephperrott
Copy link
Member

Migrate usages of whitelist in each of the ng-update selector interfaces to
be fileTypeFilter instead.

@josephperrott
refactor(cdk/schematics): change usages of whitelist in selector inte…
5a2029f 
…rfaces to fileTypeFilter

Migrate usages of whitelist in each of the ng-update selector interfaces to
be fileTypeFilter instead.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release area: cdk/schematics cdk/schematics is *not* a public API labels Sep 21, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2020
devversion
devversion reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft, but I'm providing early feedback in case it helps (due to it being a larger refactor)

@josephperrott josephperrott marked this pull request as ready for review September 21, 2020 19:15
jelbourn
jelbourn approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion
devversion approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Sep 22, 2020
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Sep 22, 2020
@josephperrott @devversion
fixup! refactor(cdk/schematics): change usages of whitelist in select…
5c8a857 
…or interfaces to fileTypeFilter

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Sep 23, 2020
@josephperrott josephperrott added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 23, 2020
@googlebot

This comment has been minimized.

Sign in to view
mmalerba added a commit to mmalerba/components that referenced this pull request Sep 29, 2020
@mmalerba @josephperrott
refactor(cdk/schematics): change usages of whitelist in selector inte…
8b42525 
…rfaces to fileTypeFilter

Same changes as angular#20619, but for the patch branch

Co-authored-by: Joey Perrott <josephperrott@gmail.com>
@mmalerba mmalerba mentioned this pull request Sep 29, 2020
Merged
mmalerba added a commit to mmalerba/components that referenced this pull request Sep 29, 2020
@mmalerba @josephperrott
refactor(cdk/schematics): change usages of whitelist in selector inte…
ae3fed9 
…rfaces to fileTypeFilter

Same changes as angular#20619, but for the patch branch

Co-authored-by: Joey Perrott <josephperrott@gmail.com>
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 30, 2020
@mmalerba mmalerba merged commit 4e689ff into angular:master Sep 30, 2020
mmalerba added a commit that referenced this pull request Sep 30, 2020
@mmalerba @josephperrott
refactor(cdk/schematics): change usages of whitelist in selector inte…
efb1035 
…rfaces to fileTypeFilter (#20681)

Same changes as #20619, but for the patch branch

Co-authored-by: Joey Perrott <josephperrott@gmail.com>

Co-authored-by: Joey Perrott <josephperrott@gmail.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/schematics cdk/schematics is *not* a public API cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephperrott @googlebot @jelbourn @devversion @mmalerba