build: update tslint rules to remove usage of whitelist in comments #20618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of the term whitelist in commenting for validateDecoratorsRule
josephperrott
added
action: merge
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 21, 2020
Comment on lines
+8
to
+9
| * Properties can be forbidden by prefixing their name with a `!`. Supports specifying a matcher for | ||
| * filtering valid files via the third argument, as well as validating all the arguments by passing |
There was a problem hiding this comment.
Suggested change
| * Properties can be forbidden by prefixing their name with a `!`. Supports specifying a matcher for | |
| * filtering valid files via the third argument, as well as validating all the arguments by passing | |
| * Properties can be forbidden by prefixing their name with a `!`. Supports an allow list for | |
| * filtering valid files via the third argument, as well as validating all the arguments by passing |
Just an optional nit comment for it being more accurate. A matcher (subjectively) implies a function/predicate to me.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of the term whitelist in commenting for validateDecoratorsRule