fix(material/core): incorrectly formatting dates in the years 0 to 99 #20612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
20418/low-date-format
branch
from
ee56b91 to
0b85bad
Compare
We were formatting dates in the years 0 to 99 incorrectly, because we pass it through the `Date` constructor which infers them as 19xx. We already had logic to handle cases like this when creating dates, but the formatting logic didn't go through the same code path. These changes extend the logic to the formatting utilities. This fix resolves part of angular#20418, but we'll also have to make some changes to the datepicker calendar so it doesn't generate out-of-bounds years.
crisbeto
force-pushed
the
20418/low-date-format
branch
from
0b85bad to
6a2f7e0
Compare
crisbeto
changed the title
mmalerba
pushed a commit
that referenced
this pull request
Oct 2, 2020
…#20612) We were formatting dates in the years 0 to 99 incorrectly, because we pass it through the `Date` constructor which infers them as 19xx. We already had logic to handle cases like this when creating dates, but the formatting logic didn't go through the same code path. These changes extend the logic to the formatting utilities. This fix resolves part of #20418, but we'll also have to make some changes to the datepicker calendar so it doesn't generate out-of-bounds years. (cherry picked from commit dd49fa6)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were formatting dates in the years 0 to 99 incorrectly, because we pass it through the
Dateconstructor which infers them as 19xx. We already had logic to handle cases like this when creating dates, but the formatting logic didn't go through the same code path. These changes extend the logic to the formatting utilities.This fix resolves part of #20418, but we'll also have to make some changes to the datepicker calendar so it doesn't generate out-of-bounds years.