Skip to content

docs: fix the harness with method's options list format in using component harnesses #20609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

docs: fix the harness with method's options list format in using component harnesses #20609

merged 1 commit into from
Sep 22, 2020

Conversation

TrevorKarjanis
Copy link
Contributor

  • Remove whitespace that causes an item in the options list of the harness with method to be
    rendered as a code block from the component harness guide. Use an alignment consistent with other lists in the file.
  • Fix a typo in the note about change detection.

Linted, built, and tested

  • Verified that the docs build output does not include an extra code block

https://imgur.com/jsrfW6W

@TrevorKarjanis
docs: fix the harness with method's options list format in using comp…
4dc060b 
…onent harnesses

Remove whitespace that causes an item in the options list of the harness with method to be
rendered as a code block.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2020
crisbeto
crisbeto approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Sep 21, 2020
@annieyw annieyw merged commit a865585 into angular:master Sep 22, 2020
annieyw pushed a commit that referenced this pull request Sep 22, 2020
@TrevorKarjanis @annieyw
docs: fix the harness with method's options list format in using comp…
a971cdf 
…onent harnesses (#20609)

Remove whitespace that causes an item in the options list of the harness with method to be
rendered as a code block.

(cherry picked from commit a865585)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TrevorKarjanis @crisbeto @devversion @googlebot @annieyw