Skip to content

docs(material/paginator): add explicit type for better formatting in docs #20608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

docs(material/paginator): add explicit type for better formatting in docs #20608

merged 1 commit into from
Sep 22, 2020

Conversation

crisbeto
Copy link
Member

MatPaginatorIntl.getRangeLabel didn't have an explicit type which was causing dgeni to output the entire initializer.

For reference:
Paginator__Angular_Material_-_Google_Chrome_2020-09-20_16-26-20

@crisbeto crisbeto added docs This issue is related to documentation merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Sep 20, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2020
@crisbeto
docs(material/paginator): add explicit type for better formatting in …
1eb46dc 
…docs

`MatPaginatorIntl.getRangeLabel` didn't have an explicit type which was causing
dgeni to output the entire initializer.
@crisbeto crisbeto force-pushed the paginator-intl-typing branch from 9ba74bc to 1eb46dc Compare September 20, 2020 13:41
@crisbeto crisbeto changed the title docs(paginator): add explicit type for better formatting in docs docs(material/paginator): add explicit type for better formatting in docs Sep 20, 2020
imjmakki
imjmakki reviewed Sep 20, 2020
View reviewed changes
Copy link

@imjmakki imjmakki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

devversion
devversion approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2020
@annieyw annieyw merged commit 2967ad0 into angular:master Sep 22, 2020
annieyw pushed a commit that referenced this pull request Sep 22, 2020
@crisbeto @annieyw
docs(material/paginator): add explicit type for better formatting in …
fc7ba87 
…docs (#20608)

`MatPaginatorIntl.getRangeLabel` didn't have an explicit type which was causing
dgeni to output the entire initializer.

(cherry picked from commit 2967ad0)
imjmakki
imjmakki reviewed Sep 24, 2020
View reviewed changes
Copy link

@imjmakki imjmakki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imjmakki imjmakki imjmakki left review comments

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @imjmakki @googlebot @annieyw