Skip to content

feat(cdk/testing): add getNativeElement to harness environments #20538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 15, 2020
Merged

feat(cdk/testing): add getNativeElement to harness environments #20538

merged 6 commits into from
Sep 15, 2020

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2020
mmalerba
mmalerba reviewed Sep 10, 2020
View reviewed changes
@wagnermaciel wagnermaciel requested a review from a team as a code owner September 11, 2020 00:11
devversion
devversion approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nit for both of the new methods

@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Sep 11, 2020
mmalerba
mmalerba reviewed Sep 11, 2020
View reviewed changes
@wagnermaciel wagnermaciel removed the action: merge The PR is ready for merge by the caretaker label Sep 11, 2020
@mmalerba mmalerba added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Sep 14, 2020
@wagnermaciel wagnermaciel merged commit 1328420 into angular:master Sep 15, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 16, 2020
@wagnermaciel wagnermaciel deleted the harness-native-element-getter branch January 14, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wagnermaciel @devversion @mmalerba @googlebot