-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(google-maps): Improve documentation for Google Maps. #20492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add new Google Maps components to documentation, including MapPolygon, MapPolyline, MapRectangle, MapCircle, MapGroundOverlay, MapKmlLayer, MapTransitLayer, MapTrafficLayer, and MapBicyclingLayer. Add instructions on how to lazy load the Google Maps JavaScript API for use with the @angular/google-maps components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple tiny capitalization nits
Co-authored-by: Jeremy Elbourn <jelbourn@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
* docs(google-maps): Improve documentation for Google Maps. Add new Google Maps components to documentation, including MapPolygon, MapPolyline, MapRectangle, MapCircle, MapGroundOverlay, MapKmlLayer, MapTransitLayer, MapTrafficLayer, and MapBicyclingLayer. Add instructions on how to lazy load the Google Maps JavaScript API for use with the @angular/google-maps components. * Apply suggestions from code review Co-authored-by: Jeremy Elbourn <jelbourn@gmail.com> Co-authored-by: Jeremy Elbourn <jelbourn@gmail.com> (cherry picked from commit 541c942)
The lazyload example has an issue with |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add new Google Maps components to documentation, including MapPolygon,
MapPolyline, MapRectangle, MapCircle, MapGroundOverlay, MapKmlLayer,
MapTransitLayer, MapTrafficLayer, and MapBicyclingLayer. Add
instructions on how to lazy load the Google Maps JavaScript API for use
with the @angular/google-maps components.