-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(cdk-experimental/menu): add examples to menu documentation #20482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
934d04b
to
8e072e4
Compare
@@ -0,0 +1,33 @@ | |||
.cdk-menu { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the examples, we try to prefix all of the styles with .example-
so it's clear where they're coming from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are the classes that the cdk directives add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can either add additional class in the example, or put all of these as child selectors, e.g.
.example-menu { ... }
.example-menuitem { ...}
/** OR **/
.example-menu .cdk-menu {
...
}
.example-menu .cdk-menuitem {
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. I see what you were saying now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jelbourn Done
|
||
.cdk-menu hr { | ||
width: 100%; | ||
color: #0000001f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the alpha notation here works in older browsers
8e072e4
to
6efb204
Compare
@jelbourn feedback should be addressed. |
6efb204
to
ea05246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I was on vacation for a bit)
@jelbourn no problem. Hope your vacation was good. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm not 100% sure if I connected the examples with menu.md correctly. PTAL.