mdc-list: support for strong focus indicators and fix incorrect cursor for non-interactive items #20476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
googlebot
added
the
cla: yes
…dicators Adds support for strong focus indicators to the MDC-based list. Also simplifies SCSS code for the hover/focus/selected styles.
…on-interactive list items The MDC list currently always shows the pointer cursor for all kinds of list items, regardless of them being interactive or not (through instantiation of the foundation). This seems to be unexpected as the pointer cursor incorrectly suggests interactivity of a list item to users. We manually reset the cursor for non-interactive list items and report an issue upstream: material-components/material-components-web#6443 Note: MDC list does no longer seem to support the `non-interactive` class we previously used, so we replace it with our own.
devversion
force-pushed
the
feat/mdc-list-focus-indicator-strong
branch
from
48ce308 to
def4c8d
Compare
mmalerba
pushed a commit
that referenced
this pull request
Sep 5, 2020
…r for non-interactive items (#20476) * feat(material-experimental/mdc-list): add support for strong focus indicators Adds support for strong focus indicators to the MDC-based list. Also simplifies SCSS code for the hover/focus/selected styles. * fix(material-experimental/mdc-list): do not show pointer cursor for non-interactive list items The MDC list currently always shows the pointer cursor for all kinds of list items, regardless of them being interactive or not (through instantiation of the foundation). This seems to be unexpected as the pointer cursor incorrectly suggests interactivity of a list item to users. We manually reset the cursor for non-interactive list items and report an issue upstream: material-components/material-components-web#6443 Note: MDC list does no longer seem to support the `non-interactive` class we previously used, so we replace it with our own. (cherry picked from commit 3474aaa)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.