Skip to content

feat(cdk/testing): support right clicking on a TestElement #20400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

feat(cdk/testing): support right clicking on a TestElement #20400

merged 1 commit into from
Oct 14, 2020

Conversation

crisbeto
Copy link
Member

Adds the ability to right click somewhere within a TestElement.

Fixes #20385.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 24, 2020
@crisbeto crisbeto force-pushed the 20385/test-element-right-click branch from a2e12ec to 799a5b7 Compare August 24, 2020 14:46
@crisbeto crisbeto marked this pull request as ready for review August 24, 2020 14:46
@crisbeto crisbeto requested review from devversion, mmalerba and a team as code owners August 24, 2020 14:46
@crisbeto crisbeto added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release and removed merge safe labels Aug 24, 2020
@crisbeto crisbeto force-pushed the 20385/test-element-right-click branch from 799a5b7 to 336d783 Compare August 24, 2020 18:46
mmalerba
mmalerba approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 24, 2020
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Sep 2, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Sep 2, 2020

@crisbeto needs rebase

@crisbeto crisbeto force-pushed the 20385/test-element-right-click branch from 336d783 to 4d6d440 Compare September 3, 2020 07:03
@crisbeto
Copy link
Member Author

crisbeto commented Sep 3, 2020

Rebased.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2020
@crisbeto crisbeto force-pushed the 20385/test-element-right-click branch 2 times, most recently from e4a6b20 to fb2dd03 Compare September 29, 2020 18:39
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 4, 2020
@annieyw
Copy link
Contributor

annieyw commented Oct 12, 2020

@crisbeto needs rebase

@crisbeto
feat(cdk/testing): support right clicking on a TestElement
c0ef982 
Adds the ability to right click somewhere within a `TestElement`.

Fixes angular#20385.
@crisbeto crisbeto force-pushed the 20385/test-element-right-click branch from fb2dd03 to c0ef982 Compare October 12, 2020 06:30
@crisbeto
Copy link
Member Author

Rebased.

@annieyw annieyw merged commit b1be164 into angular:master Oct 14, 2020
@wwjhu wwjhu mentioned this pull request Nov 10, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(testing): TestElement should have a way to right-click/open the context menu
5 participants
@crisbeto @mmalerba @annieyw @devversion @googlebot